This repository has been archived by the owner on Jul 5, 2018. It is now read-only.
about page, localization and select option localization #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing images/ added about icon with click event to the welcome page <https://bugzilla.wikimedia.org/show_bug.cgi?id=38075> added about page with mock-up content <https://bugzilla.wikimedia.org/show_bug.cgi?id=38075> added about page mock-content to the messages-en.properties file added data-localize-msg to jquery.localize -> allows for valid html markup, provides a method to circumvent ie issues mentioned with <msg key=""/> and <html:msg key=""/> added data-option-msg to jquery.localize -> provides a resolution to the issue where jquery.localize cannot .find the msg within the <option> elements added to the jquery.localize embedded documentation set the select font-size to 100% and re-positioned the select to better align with the back icon -> shows up on the results-page header
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for your consideration ....
list of changes