add about page #58
add about page #58
Conversation
|
Depends on #59 |
|
I have reservations about the localization library changes so it would be good to have this use msg tags Also we should use something other than ipsum lorem text. The text here - http://www.wikilovesmonuments.org/294/ - seems like a good starting point. |
|
Pinging @dan-nl, because I'm not sure if GH notifications work out there properly |
|
sorry guys, didn't see this. i'm all for not forking jquery.localize.js within this repo, however, the change does resolve the <option> element issue as well as insuring valid markup, which i believe is important no matter where the app ends up being used, still, i agree, it would be better to fork the original repo and get buy-in there on the changes. anyone know the git url to it? if necessary, go ahead and use the <msg> elements for now and i'll see if i can get buy-in on the changes to the original repo if it exists. the link jdlrobson mentions seems like a good place to start with for the actual copy. who usually handles the copy for this app, multichill? |
|
I made some adjustments based on Dan's work. Would be good to get multichill to review but I think it's a good starting point and better than nothing. |
| @@ -160,6 +160,10 @@ button { | |||
| border: 0px; | |||
| } | |||
|
|
|||
| header button { | |||
| margin: 0; | |||
There was a problem hiding this comment.
overrides browser default margin for buttons
adapted by @jdlrobson based on work by @dan-nl added about icon with click event to the welcome page <https://bugzilla.wikimedia.org/show_bug.cgi?id=38075> added about page with suggested content <https://bugzilla.wikimedia.org/show_bug.cgi?id=38075> added about page suggested content to the messages-en.properties file required styling fixes
|
Feel free to merge after adding qqq. Everything else looks ok. The internet gods are not kind to me. |
|
merged |
added about icon with click event to the welcome page https://bugzilla.wikimedia.org/show_bug.cgi?id=38075
added about page with mock-up content https://bugzilla.wikimedia.org/show_bug.cgi?id=38075
added about page mock-content to the messages-en.properties file