Push notifications. #1641
Merged
Push notifications. #1641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Iec5e0aa575d1535b74e3aa0232e8da33974ba28f
Change-Id: Iabef45609eadacf5b85603dbd040c4c9e962e802
Change-Id: I2af423ef1e01045a42dcda432dbcd7b5597de01d
Change-Id: I52e9d563fa316bea6bc127f4e78ca9098f1d5112
Change-Id: I4f25c7ebf033c227d707c678e9467be3ab964693
Change-Id: I3104e1d909f937e28f82f2721809ac9134cd697e
Change-Id: I24ffaf0d1f85dc4cf25ec8601963f1a4fb5f1873
Change-Id: I6da83f200d67fed7339e2d8837bfc8ff696d41e1
Change-Id: Iabade356db7a417047c6e5926035f801b5f52350
…to push Change-Id: Ib893476f0ec63c6c2a8bea5a5fd1d3302f5b6c1b
Change-Id: I360f60822a48dfe9716f197347541e9b6b3be2af
Change-Id: If2330f9b4fc90858364cfae24457782355db8f42
Change-Id: Id16e4fca5305d8e54955483ab76bf2a86c2cf4da
Change-Id: Ice4ad24976c0e1053c166e8dbbd79d9dc4457737
Change-Id: I27c692b4fa4c88a34b30c59b89fd6feae838584d
Change-Id: I8ba4712cf526e04a8ddb4ce6fb92f4d6e7a3bb99
Change-Id: I9bed61dec905fc1013166a2113afe97045b387d7
Change-Id: I4c6e493f83924b6c2a9296d24621bcfeaf6962ae
Change-Id: I3106a0e1e1d3f7592d1ca0024cf812b1a2cfcfe2
Split off proprietary-dependent code into separate sourceSet.
|
@cooltey @sharvaniharan This is now ready for review / merge. |
cooltey
reviewed
Oct 15, 2020
app/src/extra/java/org/wikipedia/push/WikipediaFirebaseMessagingService.kt
Outdated
Show resolved
Hide resolved
app/src/extra/java/org/wikipedia/push/WikipediaFirebaseMessagingService.kt
Outdated
Show resolved
Hide resolved
Change-Id: I59d07c889c1e8dca3182cdd62221cc6f0e76cdcd
|
|
|
Lgtm... @cooltey please merge when you are done with review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.