Fix flaky sidebar #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`dispatchEvent('click')` won't work as desired on label elements unless an event
handler is attached like checkboxHack.js adds. Because the menuState code could
execute before the checkboxHack.js code executed, a race condition was possible
where the mobile sidebar failed to show. Using `.click` instead avoids this race
condition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dispatchEvent('click')won't work as desired on label elements unless an eventhandler is attached like checkboxHack.js adds. Because the menuState code could
execute before the checkboxHack.js code executed, a race condition was possible
where the mobile sidebar failed to show. Using
.clickinstead avoids this racecondition.