Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky sidebar #29

Merged
merged 1 commit into from
May 18, 2022
Merged

Fix flaky sidebar #29

merged 1 commit into from
May 18, 2022

Commits on May 18, 2022

  1. Fix flaky sidebar 

    `dispatchEvent('click')` won't work as desired on label elements unless an event
handler is attached like checkboxHack.js adds. Because the menuState code could
execute before the checkboxHack.js code executed, a race condition was possible
where the mobile sidebar failed to show. Using `.click` instead avoids this race
condition.
    Nick Ray committed May 18, 2022
    Configuration menu
    Copy the full SHA
    ab3c522 View commit details
    Browse the repository at this point in the history