Merge pull request #1988 from wikimedia/fix/edit-pencil-peek/T182902

Fix edit pencil peeking when they should not
wikimedia · Dec 15, 2017 · 9aa68e2 · 9aa68e2
2 parents b1227bf + 971e044
commit 9aa68e2
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 1 deletion.
diff --git a/Wikipedia/Code/WebViewController.m b/Wikipedia/Code/WebViewController.m
@@ -575,7 +575,6 @@ - (WKWebViewConfiguration *)configuration {
     WKUserContentController *userContentController = [[WKUserContentController alloc] init];
 
     NSArray *handlerNames = @[
-        @"peek",
         @"linkClicked",
         @"imageClicked",
         @"referenceClicked",

diff --git a/Wikipedia/assets/index.js b/Wikipedia/assets/index.js
@@ -733,6 +733,7 @@ const applyTransformationsToFragment = (fragment, article, isLead) => {
       const heading = fragment.querySelector('.section_heading[data-id]')
       heading.appendChild(requirements.editTransform.newEditSectionButton(fragment, heading.getAttribute('data-id')))
     }
+    fragment.querySelectorAll('a.pagelib_edit_section_link').forEach(anchor => {anchor.href = 'WMFEditPencil'});
   }
 
   const tableFooterDivClickCallback = container => {

diff --git a/www/js/sections.js b/www/js/sections.js
@@ -152,6 +152,7 @@ const applyTransformationsToFragment = (fragment, article, isLead) => {
       const heading = fragment.querySelector('.section_heading[data-id]')
       heading.appendChild(requirements.editTransform.newEditSectionButton(fragment, heading.getAttribute('data-id')))
     }
+    fragment.querySelectorAll('a.pagelib_edit_section_link').forEach(anchor => {anchor.href = 'WMFEditPencil'});
   }
 
   const tableFooterDivClickCallback = container => {