Merge pull request #4821 from wikimedia/image-recs-voiceover

Image Recommendations - Hide feature when VoiceOver is on
wikimedia · Apr 25, 2024 · d172db3 · d172db3
2 parents 23bbf28 + 341e8b5
commit d172db3
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/Wikipedia/Code/ExploreFeedSettingsViewController.swift b/Wikipedia/Code/ExploreFeedSettingsViewController.swift
@@ -202,7 +202,7 @@ class ExploreFeedSettingsViewController: BaseExploreFeedSettingsViewController {
         let continueReading = FeedCard(contentGroupKind: .continueReading, displayType: displayType)
         let relatedPages = FeedCard(contentGroupKind: .relatedPages, displayType: displayType)
         let suggestedEdits = FeedCard(contentGroupKind: .suggestedEdits, displayType: displayType)
-        if FeatureFlags.needsImageRecommendations {
+        if FeatureFlags.needsImageRecommendations && !UIAccessibility.isVoiceOverRunning {
             return [inTheNews, onThisDay, featuredArticle, topRead, places, randomizer, pictureOfTheDay, continueReading, relatedPages, suggestedEdits]
         } else {
             return [inTheNews, onThisDay, featuredArticle, topRead, places, randomizer, pictureOfTheDay, continueReading, relatedPages]

diff --git a/Wikipedia/Code/ExploreViewController.swift b/Wikipedia/Code/ExploreViewController.swift
@@ -66,8 +66,9 @@ class ExploreViewController: ColumnarCollectionViewController, ExploreCardViewCo
 #if UITEST
         presentUITestHelperController()
 #endif
-
-        presentImageRecommendationsFeatureAnnouncementIfNeeded()
+        if !UIAccessibility.isVoiceOverRunning {
+            presentImageRecommendationsFeatureAnnouncementIfNeeded()
+        }
     }
 
     override func viewWillHaveFirstAppearance(_ animated: Bool) {

diff --git a/Wikipedia/Code/WMFSuggestedEditsContentSource.m b/Wikipedia/Code/WMFSuggestedEditsContentSource.m
@@ -55,7 +55,7 @@ - (void)loadNewContentInManagedObjectContext:(nonnull NSManagedObjectContext *)m
 
         [group waitInBackgroundWithCompletion:^{
             if (currentUser) {
-                if ((currentUser.editCount > 50 && !currentUser.isBlocked && hasImageRecommendations) || WMFFeatureFlags.forceImageRecommendationsExploreCard) {
+                if ((currentUser.editCount > 50 && !currentUser.isBlocked && hasImageRecommendations && !UIAccessibilityIsVoiceOverRunning()) || WMFFeatureFlags.forceImageRecommendationsExploreCard) {
 
                     NSURL *URL = [WMFContentGroup suggestedEditsURL];