Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image Recommendations - Hide feature when VoiceOver is on #4821

Merged
merged 3 commits into from
Apr 25, 2024

Conversation

mazevedofs
Copy link
Collaborator

Phabricator: https://phabricator.wikimedia.org/T360035

Notes

  • This feature hides the feature when VoiceOver is activated
  • It's not being done upon NotificationCenter UIAccessibilityVoiceOverStatusDidChangeNotification assuming a user would have it on when launching the app, avoiding an explore feed refresh and the operation of removing and inserting the card
  • So I'm checking if VoiceOver is on when doing all the checks to display the card

Test Steps

  1. Run a fresh install of the app with VoiceOver already on
  2. Make sure the new feature modal, explore feed card, and explore feed setting option for VoiceOver are not showing
  3. Turn VoiceOver off, run another fresh install - make sure all the above items appear normally

@mazevedofs mazevedofs changed the title Suppress Image Recommendations when VoiceOver is on Image Recommendations - Hide feature when VoiceOver is on Apr 25, 2024
@tonisevener tonisevener self-assigned this Apr 25, 2024
@tonisevener tonisevener removed their assignment Apr 25, 2024
@tonisevener tonisevener merged commit d172db3 into main Apr 25, 2024
4 checks passed
@tonisevener tonisevener deleted the image-recs-voiceover branch April 25, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants