Small JS cleanups #1958
Merged
Small JS cleanups #1958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ultimately all of the transforms which had formerly been in files in "/tranforms/" folder are moving to the page library (once they're consolidated with Android versions). For transforms which have already made this migration the extra wiring involved in keeping their invocation in these separate files adds unnecessary complexity.
Hiding file page edit pencils (on pages like 'File:Cat.jpg') had regressed as a result of the headless section transforming/loading. Also confirmed with Carolyn we don't need to disable file page image taps any more.
Transforms now happen on section fragments rather than entire articles, plus we know that it's not a lead section.
joewalsh
approved these changes
Nov 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up cleanups to
Switch to using headless section transform and attachment: https://phabricator.wikimedia.org/T175320Ultimately all of the transforms which had formerly been in files in "/tranforms/" folder are moving to the page library (once they're consolidated with Android versions). For transforms which have already made this migration the extra wiring involved in keeping their invocation in these separate files adds unnecessary complexity.