Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small JS cleanups #1958

Merged
merged 6 commits into from Nov 30, 2017
Merged

Small JS cleanups #1958

merged 6 commits into from Nov 30, 2017

Commits on Nov 30, 2017

  1. Remove unneeded image widening JS file. 

    Ultimately all of the transforms which had formerly been in files in "/tranforms/" folder are moving to the page library (once they're consolidated with Android versions). For transforms which have already made this migration the extra wiring involved in keeping their invocation in these separate files adds unnecessary complexity.
    @montehurd
    montehurd committed Nov 30, 2017
    Configuration menu
    Copy the full SHA
    c41eddb View commit details
    Browse the repository at this point in the history

  2. Remove unneeded 'disable file page edit' file. 

    Hiding file page edit pencils (on pages like 'File:Cat.jpg') had regressed as a result of the headless section transforming/loading.

Also confirmed with Carolyn we don't need to disable file page image taps any more.
    @montehurd
    montehurd committed Nov 30, 2017
    Configuration menu
    Copy the full SHA
    e82d493 View commit details
    Browse the repository at this point in the history

  3. Remove unneeded edit button file.

    @montehurd
    montehurd committed Nov 30, 2017
    Configuration menu
    Copy the full SHA
    94ca336 View commit details
    Browse the repository at this point in the history

  4. Simplify non-lead edit pencil addition. 

    Transforms now happen on section fragments rather than entire articles, plus we know that it's not a lead section.
    @montehurd
    montehurd committed Nov 30, 2017
    Configuration menu
    Copy the full SHA
    dadbd54 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'develop' into update/js-follow-up-cleanups/T175320

    @joewalsh
    joewalsh committed Nov 30, 2017
    Configuration menu
    Copy the full SHA
    a212abd View commit details
    Browse the repository at this point in the history

  6. Merge branch 'develop' into update/js-follow-up-cleanups/T175320

    @joewalsh
    joewalsh committed Nov 30, 2017
    Configuration menu
    Copy the full SHA
    1d2d84a View commit details
    Browse the repository at this point in the history