Use new pagelib reference collection bits. #2295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't include the pagelib version bump because the PR moving those bits to the page lib isn't merged at the moment. As soon as wikimedia/wikimedia-page-library#140 is merged we can bump the pagelib version (as a new commit on this PR) and it should work.
montehurd
commented
May 9, 2018
| * @return {void} | ||
| */ | ||
| const reformatReferenceItemRectToBridgeToCGRect = referenceItem => { | ||
| referenceItem.rect = { |
There was a problem hiding this comment.
This was needed so the pagelib didn't have to know about iOS specific CGRect bridging details. The pagelib keeps the rect as a standard JS ClientRect.
joewalsh
approved these changes
Jun 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://phabricator.wikimedia.org/T194444
This doesn't include the pagelib version bump because the PR moving those bits to the page lib isn't merged at the moment. As soon as wikimedia/wikimedia-page-library#140 is merged we can bump the pagelib version (as a new commit on this PR) and it should work.Question:5.8.2or5.9? (kinda also depends on how quickly the pagelib PR clears CR)Josh said ok for
5.8.2