New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use new pagelib reference collection bits. #2295
Merged
Merged
Changes from 2 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
1225fad
Use new pagelib reference collection bits.
montehurd 3190517
Merge branch 'develop' into useConsolidatedRefCollection
montehurd a9cfe74
Merge branch 'develop' into useConsolidatedRefCollection
montehurd 71e6b35
Merge branch 'develop' into useConsolidatedRefCollection
montehurd 8019885
Merge branch 'develop' into useConsolidatedRefCollection
joewalsh 0d3dc01
Merge branch 'develop' into useConsolidatedRefCollection
b03c0e2
Merge branch 'develop' into useConsolidatedRefCollection
7c49c47
Merge branch 'develop' into useConsolidatedRefCollection
82b7b56
Merge branch 'develop' into useConsolidatedRefCollection
7a9773a
Merge branch 'develop' into useConsolidatedRefCollection
montehurd 2c41b9f
Merge branch 'develop' into useConsolidatedRefCollection
montehurd eba2cce
Merge branch 'develop' into useConsolidatedRefCollection
montehurd 1af6759
Merge branch 'develop' into useConsolidatedRefCollection
joewalsh 025e55e
Merge branch 'develop' into useConsolidatedRefCollection
montehurd 8f6ba6c
Merge branch 'develop' into useConsolidatedRefCollection
montehurd c00de9a
Update pagelib to 6.1.0 to use its reference collection.
montehurd c0966dd
Merge branch 'develop' into useConsolidatedRefCollection
wmf-apps-ci File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was needed so the pagelib didn't have to know about iOS specific CGRect bridging details. The pagelib keeps the rect as a standard JS ClientRect.