Wire up revision 'thanking' #3318
Conversation
has sub-title label and slightly different theme colors
montehurd
added
Changes welcome
Dependent PR
There was a problem hiding this comment.
Looks good! I had some trouble getting a thank to go through on labs, had some token issues but that should all work once we move to prod, for now I faked a success to test the UI. I do think we'll need to remember that this revision was thanked for a selected state when we return to this screen. I'll look into that & fixing the up / down arrow disabled state edge cases tomorrow.
| } | ||
| guard WMFAuthenticationManager.sharedInstance.isLoggedIn else { | ||
| wmf_showLoginOrCreateAccountToThankRevisionAuthorPanel(theme: theme, dismissHandler: nil, loginSuccessCompletion: { | ||
| self.apply(theme: self.theme) |
There was a problem hiding this comment.
Why apply the theme here?
There was a problem hiding this comment.
I do think we'll need to remember that this revision was thanked for a selected state when we return to this screen.
iirc josh said that was a nice-to-have but not necessary
There was a problem hiding this comment.
cant remember why the theme is applied there 😂
https://phabricator.wikimedia.org/T228790
Based on #3295
Before merging update
basetodevelop(after #3295 is merged)