Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manually check for Farsi when searching for languages #4004

Merged
merged 2 commits into from
Jul 30, 2021
Merged

Manually check for Farsi when searching for languages #4004

merged 2 commits into from
Jul 30, 2021

Conversation

mcleinman
Copy link
Contributor

Phabricator: https://phabricator.wikimedia.org/T107530

Notes

  • Quick hack to check for Farsi in search box, per discussion.
  • Also refactored out some duplicated code.

Test Steps

  1. Run app, go to adding languages.
  2. Search for "Farsi". After every letter typed, "Persian" should be an option as well as the expected results.
  3. "Persian" should also be available when searching for "Persian", of course.

tonisevener
tonisevener approved these changes Jul 29, 2021
View reviewed changes
Copy link
Collaborator

@tonisevener tonisevener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working well for me! For whatever reason GitHub is struggling to update with main for me. I'll try merging tomorrow.

@tonisevener tonisevener merged commit 54b0c19 into main Jul 30, 2021
@tonisevener tonisevener deleted the T107530 branch July 30, 2021 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonisevener tonisevener tonisevener approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcleinman @tonisevener