New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add banner to subscription action #4312
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! I didn't realize this view was so broken with bottom alignment and icons, thanks for working through it. I made a couple of minor tweaks in 966837e, hope that's okay:
- There were some console constraint complaints, and after some digging it looks like there already was a leading constraint in the xib that your new
titleViewLeading
constraint conflicted with. So I exposed that xib constraint and am setting it to 50 instead. - I aligned some views to the superview
safeAreaLayoutGuide
instead of the extra safe area padding number. Both of these changes should only affect bottom and icon banners, so I think it's pretty safe.
override func viewDidLoad() { | ||
super.viewDidLoad() | ||
|
||
navigationItem.title = WMFLocalizedString("talk-pages-view-title", value: "Talk", comment: "Title of user and article talk pages view.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for cleaning these up!
Phabricator: https://phabricator.wikimedia.org/T311639
Notes
Test Steps