New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add banner to subscription action #4312
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
3c9d270
Add localized strings, chenge enum name to add all talk page strings
mazevedofs da51b09
Add alert to subscription action
mazevedofs 92b20c0
Move strings to enum
mazevedofs f6585c4
Add call to API to subscribe to topic
mazevedofs ab50861
Refactor alert logic to separate function
mazevedofs 3cbc4e9
Move function out of extension to class
mazevedofs af5dd2c
remove orphaned todo comment
mazevedofs a2be971
Remove whitespace
mazevedofs 60dcba5
Add fetchSubscriptions method to data controller
mazevedofs 75732f1
Remove call to API from talk page vc
mazevedofs df1037c
Fix RMessage alert view icon dispaly issue
mazevedofs 74a055e
Keep consistent identation in file
mazevedofs fd3999f
Add bottom padding to RMessage alert
mazevedofs 4a72f4a
Revert change
mazevedofs 4f284f1
remove uncessary code
mazevedofs 966837e
Minor tweaks for bottom safe area & leading space for icon
tonisevener 9220d63
Merge branch 'main' into T311639-subscription
tonisevener 05ca6b1
Remove test code
tonisevener File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for cleaning these up!