Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Apple fine print to native donate form #4655

Merged
merged 4 commits into from
Oct 11, 2023
Merged

Conversation

tonisevener
Copy link
Collaborator

@tonisevener tonisevener commented Oct 11, 2023

Phabricator:
https://phabricator.wikimedia.org/T345846

Notes

Added "Apple is not in charge of raising money for this purpose." fine print to the bottom of the native donate form. Marking as hold until design review is complete.

Test Steps

  1. Log into iOS Sandbox Tester Apple ID (see 1Password) in test device iOS Settings. Do not enable 2 factor auth.
  2. In Wallet app, add Test Apple Pay card.
  3. Change device region to NL or IT.
  4. On Staging scheme, fresh install and launch app.
  5. On Explore feed, background, then foreground, then pull to refresh on Explore feed to fetch latest campaigns.
    In Settings, you should now see a "Donate to Wikipedia" cell, tap it. Tap "Donate with Apple Pay" option in alert view.
  6. Note new fine print on donate form.

Screenshots

IMG_0240

- The staging environment was not permanent, so it is not useful moving forward
@tonisevener tonisevener marked this pull request as draft October 11, 2023 15:43
@tonisevener tonisevener changed the title [HOLD] Add Apple fine print to native donate form Add Apple fine print to native donate form Oct 11, 2023
@tonisevener tonisevener marked this pull request as ready for review October 11, 2023 16:28
@staykids staykids self-assigned this Oct 11, 2023
Copy link
Contributor

@staykids staykids left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very sweet seeing this native Apple Pay stuff come together! I created a new sandbox acct. for myself to test with to see more of the end to (almost) end process myself.

@staykids staykids merged commit e67c45c into main Oct 11, 2023
2 checks passed
@staykids staykids deleted the apple-pay-form-fine-print branch October 11, 2023 22:11
@staykids staykids removed their assignment Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants