Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change payment method prompt from alert view to action sheet #4656

Merged
merged 2 commits into from Oct 12, 2023

Conversation

tonisevener
Copy link
Collaborator

Phabricator:
https://phabricator.wikimedia.org/T345851#9236850

Notes

This PR changes the payment method prompt from alert view to action sheet.

Prior to test steps: make these changes from #4655 locally, if needed.

Test Steps

  1. Log into iOS Sandbox Tester Apple ID (see 1Password) in test device iOS Settings. Do not enable 2 factor auth.
    In Wallet app, add Test Apple Pay card.
  2. Change device region to NL or IT.
  3. On Staging scheme, fresh install and launch app.
  4. On Explore feed, background, then foreground, then pull to refresh on Explore feed to fetch latest campaigns.
  5. In Settings, you should now see an action sheet after tapping "Donate with Apple Pay" instead of an alert view.
  6. Visit an article on EN Wikipedia. Tap "Donate" on the campaign modal. You should now see an action sheet instead of an alert view.

Screenshots/Videos

IMG_0242
IMG_0241

IMG_1271
IMG_1266
IMG_1270
IMG_1269

@staykids staykids self-assigned this Oct 11, 2023
@staykids staykids merged commit c675d42 into main Oct 12, 2023
2 checks passed
@staykids staykids deleted the apple-pay-action-sheet branch October 12, 2023 00:11
@staykids staykids removed their assignment Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants