Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image Recommendations - Add empty state #4801

Merged
merged 8 commits into from
Apr 1, 2024
Merged

Image Recommendations - Add empty state #4801

merged 8 commits into from
Apr 1, 2024

Conversation

tonisevener
Copy link
Collaborator

@tonisevener tonisevener commented Mar 29, 2024 •
edited

Phabricator: https://phabricator.wikimedia.org/T358926

Notes

This PR uses our existing WKEmptyView component for the empty state in image recommendations.

Test Steps

  1. On Staging, tap the Explore feed card to reach to the Image Recommendations feature.
  2. Tap "Not sure" on recommendation 10 times to reach the end of the initial fetch list.
  3. Confirm empty state appears.
  4. Regression - confirm Watchlist empty states are unchanged.

Screenshots/Videos

IMG_0340

@tonisevener tonisevener requested review from a team and staykids and removed request for a team March 29, 2024 18:31
@staykids staykids self-assigned this Apr 1, 2024
@staykids staykids removed their assignment Apr 1, 2024
@staykids staykids merged commit 5fcf663 into main Apr 1, 2024
4 checks passed
@staykids staykids deleted the image-rec-empty-state branch April 1, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@staykids staykids staykids approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@tonisevener @staykids