Image recommendations - Add tooltips #4813
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phabricator: https://phabricator.wikimedia.org/T359135
Notes
This PR introduces a new component to the Components package for displaying a series of tooltips. The tooltip design itself is displayed via UIKit in
WKTooltipViewController
. I am also presenting the tooltips through a view controller protocol extension calledWKTooltipPresenting
. This extension is designed to handle the display and dismissal of the tooltips, so that the implementing view controller only needs to worry about constructing the tooltip view models.As a part of this, I removed the full screen modal handling for iPad, to confirm tooltips are aligned properly. I think we should keep it removed for now to make the feature usable on iPad. We can fine-tune it later when we pick up https://phabricator.wikimedia.org/T360036.
Test Steps