Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image recommendations - Add tooltips #4813

Merged
merged 14 commits into from
Apr 24, 2024
Merged

Image recommendations - Add tooltips #4813

merged 14 commits into from
Apr 24, 2024

Commits on Apr 17, 2024

  1. Add new tooltip components

    @tonisevener
    tonisevener committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    14507de View commit details
    Browse the repository at this point in the history

  2. Minor color adjustments

    @tonisevener
    tonisevener committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    43ed547 View commit details
    Browse the repository at this point in the history

  3. Update data controller to handle tooltips user defaults flag

    @tonisevener
    tonisevener committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    b935e76 View commit details
    Browse the repository at this point in the history

  4. Conform topmost presented view controller to WKTooltipPresenting

    @tonisevener
    tonisevener committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    ffa9eab View commit details
    Browse the repository at this point in the history

  5. Add tooltip strings to view model

    @tonisevener
    tonisevener committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    2f5ea7c View commit details
    Browse the repository at this point in the history

  6. Present tooltips from WKImageReccommendationsViewController 

    - Also forcing iPad to use bottom sheet
    @tonisevener
    tonisevener committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    a97b16e View commit details
    Browse the repository at this point in the history

  7. Additional strings changes

    @tonisevener
    tonisevener committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    716a47f View commit details
    Browse the repository at this point in the history

  8. Capture article summary div frame from SwiftUI 

    - used in UIKit context to determine sourceRect of first tooltip
    @tonisevener
    tonisevener committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    d2aa9ee View commit details
    Browse the repository at this point in the history

  9. Minor final tweaks

    @tonisevener
    tonisevener committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    c9a4728 View commit details
    Browse the repository at this point in the history

  10. Fix tests

    @tonisevener
    tonisevener committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    3b80895 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2024

  1. Merge branch 'main' into image-rec-tooltips

    @tonisevener
    tonisevener committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    c63ecea View commit details
    Browse the repository at this point in the history

  2. Strings changes from building

    @tonisevener
    tonisevener committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    8ce8a55 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2024

  1. Merge branch 'main' into image-rec-tooltips

    @tonisevener
    tonisevener committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    a523c89 View commit details
    Browse the repository at this point in the history

  2. Compile fix after merge

    @tonisevener
    tonisevener committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    eb3d9c1 View commit details
    Browse the repository at this point in the history