Use particular campaign ID format for fundraising metrics #4848
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phabricator: https://phabricator.wikimedia.org/T352717
Notes
This PR modifies the
campaign_id
format when sending fundraising metrics. Note that we do still need to retain the old format and send to thesubmitPayment
endpoint. I kept that logic as-is (generally calledbannerID
and is sourced from the config asset'sutm_source
value), but I updated all the metrics call sites to accept a newmetricsID
.Test Steps (Optional)
enJP_2024_05_iOS
.enJP_2024_05_iOS
.app_2024_JP_iOS_control
. Stop Xcode now to avoid charges.