Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double check all images are rendering correctly #14

Closed
bogreudell opened this issue Aug 31, 2018 · 2 comments
Closed

Double check all images are rendering correctly #14

bogreudell opened this issue Aug 31, 2018 · 2 comments
Assignees
Labels
help wanted Extra attention is needed

Comments

@bogreudell
Copy link
Contributor

Some are echoed in the background style of divs and other elements. This is to make them crop more easily (hint: user background-size:cover;)

@bogreudell bogreudell added the help wanted Extra attention is needed label Aug 31, 2018
@bogreudell
Copy link
Contributor Author

bogreudell commented Sep 5, 2018

@robinmetral

  • Video alert is rendering correctly, as long as the video post in question has a featured image. Same goes for featured items (videos)
  • Homepage primary sections are working fine
  • Featured blog posts (recent News) wasn't working, so I circumvented this by adding a custom field to the news item post type. Will explain and help you set up during our next call

@robinmetral
Copy link
Contributor

I opened a PR for this, already fixed the member background-images.

Will continue working on that branch after you tell me about the featured blog posts issue on our call, @bogreudell!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants