[WFLY-12802] Quickstart for MP Config 1.4 #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@emmartins I believe this is ready for review. Only OpenShift tests are missing which are not a part of this PR. |
xstefank
changed the title
rhusar
reviewed
Mar 7, 2020
Comment on lines
+54
to
+55
| -DarchetypeGroupId=org.apache.maven.archetypes \ | ||
| -DarchetypeArtifactId=maven-archetype-webapp |
There was a problem hiding this comment.
Just wondering, why not use the wildfly archetype?
There was a problem hiding this comment.
@rhusar is there any without Java/Jakarta mentions? I think that is why I chose to stick with default maven ones.
There was a problem hiding this comment.
If we could use any WildFly archetypes we should have merged Stefano's archetype - the problem is none of them are presently available to us once we use the quickstarts with EAP.
rhusar
suggested changes
Mar 16, 2020
| * Simple tests for MicroProfile Config quickstart. Arquillian deploys an @AR archive to the application server, which | ||
| * contains several endpoints exposing injected configuration values and verifies that they are correctly invoked. | ||
| * | ||
| * @author <a href="mstefank@redhat.com>Martin Stefanko</a> |
| import java.nio.file.Paths; | ||
|
|
||
| /** | ||
| * Simple tests for MicroProfile Config quickstart. Arquillian deploys an @AR archive to the application server, which |
rhusar
suggested changes
Mar 16, 2020
| .addAsResource("META-INF/services/org.eclipse.microprofile.config.spi.ConfigSourceProvider") | ||
| .addAsResource("META-INF/services/org.eclipse.microprofile.config.spi.Converter") | ||
| // enable CDI | ||
| .addAsManifestResource(EmptyAsset.INSTANCE, "beans.xml"); } |
xstefank
force-pushed
the
WFLY-12802
branch
5 times, most recently
from
7982e43
to
7ecf6be
Compare
|
@xstefank Needs a rebase now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/WFLY-12802