[WFLY-12829] Quickstart for MP OpenTracing 1.3 #380
Conversation
microprofile-opentracing/README.adoc
Outdated
| following content: | ||
|
|
||
| NOTE: The new file should be created in | ||
| `src/main/java/org/quickstart/microprofile/rest/client/JaxRsApplication.java`. |
There was a problem hiding this comment.
Is this path intentional? Didn't you mean this one instead? src/main/java/org/wildfly/quickstart/microprofile/opentracing/JaxRsApplication.java
| } | ||
| ---- | ||
|
|
||
| And rebuild and deploy the application |
There was a problem hiding this comment.
The import org.eclipse.microprofile.opentracing.Traced; is also required. But maybe it is omitted intentionally, to simplify this? I'm okay with this, just saying...
There was a problem hiding this comment.
Yes, this is intentional. Automatic import resolution should be able to handle the import.
|
|
||
| [source,java] | ||
| ---- | ||
| @Inject |
There was a problem hiding this comment.
The import javax.inject.Inject; is also required. But maybe it is omitted intentionally, to simplify this? Alternatively, we could put directly @javax.inject.Inject... Anyway, I can live with this as it is, just saying...
There was a problem hiding this comment.
Yes, this is also intentional. I would expect that the automatic import resolution should be able to handle this. If we receive reports that it is not, I will update it everywhere.
microprofile-opentracing/README.adoc
Outdated
| [source,options="nowrap"] | ||
| ---- | ||
| mvn archetype:generate \ | ||
| -DgroupId=org.wildfly.quickstart.microprofile.config \ |
There was a problem hiding this comment.
s/org.wildfly.quickstart.microprofile.config/org.wildfly.quickstart.microprofile.opentracing
| * Simple tests for MicroProfile OpenTracing quickstart. Arquillian deploys an JAR archive to the application server, which | ||
| * contains several REST endpoint and verifies that they are correctly invoked and the created spans are collected. | ||
| * | ||
| * @author <a href="mstefank@redhat.com>Martin Stefanko</a> |
microprofile-opentracing/pom.xml
Outdated
| <version>2.0.2</version> | ||
| <scope>provided</scope> | ||
| </dependency> | ||
| <!-- Import the Jakarta REST API, we use provided scode as the API is included in WildFly --> |
xstefank
force-pushed
the
WFLY-12829
branch
3 times, most recently
from
6abdcd9
to
5e0bae2
Compare
xstefank
changed the title
xstefank
force-pushed
the
WFLY-12829
branch
2 times, most recently
from
bab0e32
to
755ced0
Compare
https://issues.redhat.com/browse/WFLY-12829