Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WFLY-13268 MP Fault Tolerance quickstart cannot resolve dependencies … #401

Merged
merged 1 commit into from Apr 22, 2020

Conversation

rhusar
Copy link
Member

@rhusar rhusar commented Mar 23, 2020

…with wildlfy-microprofile BOM

Jira
https://issues.redhat.com/browse/WFLY-13268

Downstream
#402

Copy link
Member

@xstefank xstefank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand why this is necessary but we should try to remove Jakarta BOMs from MP quickstarts asap after the release (if not possible before) as users should not pull Jakarta BOM in their MicroProfile application. There is already a lot of confusion out there and as we've discussed before a lot of corner cases between Jakarta and MP are not covered so we shouldn't encourage users to use them both at the same time.

microprofile-fault-tolerance/pom.xml Show resolved Hide resolved
@rhusar
Copy link
Member Author

rhusar commented Mar 23, 2020

+1 @xstefank I agree that the widlfly-microprofile BOM should be sufficient and we should not mix and match.

@emmartins
Copy link
Contributor

emmartins commented Mar 23, 2020

@rhusar IMHO You should explain why you importing the BOMs, e.g. XML comment before each import (in both the pom.xml and README.adoc XML snippet)

@rhusar
Copy link
Member Author

rhusar commented Mar 23, 2020

@emmartins I could but this doesn't seem to be a standard, e.g. https://github.com/wildfly/quickstart/blame/master/microprofile-jwt/README.adoc#L180-L200

@emmartins
Copy link
Contributor

@rhusar it's something that should be done for all quickstarts once BOMs imports are added

@rhusar
Copy link
Member Author

rhusar commented Mar 23, 2020

@emmartins OK, added a note as requested.

@emmartins emmartins merged commit b2f1c2d into wildfly:master Apr 22, 2020
@rhusar rhusar deleted the WFLY-13268 branch April 22, 2020 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants