Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WFLY-13464 Change server startup documentation to reference local installation and standalone-microprofile.xml #416

Merged
merged 1 commit into from May 15, 2020

Conversation

pferraro
Copy link
Contributor

@pferraro pferraro changed the title WFLY-13464 Usage of wildfly maven plugin in microprofile-openapi QS should reference JBOSS_HOME WFLY-13464 Change server startup documentation to reference local installation and standalone-microprofile.xml May 14, 2020
@emmartins
Copy link
Contributor

  1. We don't need the wildfly maven plugin config in the pom.xml anymore right?
  2. It would still be preferable to include the start standalone section instead, for instance it includes a note for Windows users

@rhusar
Copy link
Member

rhusar commented May 15, 2020

@emmartins Re no. 1, no, it's still needed for wildfly:deploy target (see https://github.com/wildfly/quickstart/pull/416/files#diff-d3218658e824c230fa8fcedb01baa886R38).

microprofile-openapi/README.adoc Outdated Show resolved Hide resolved
@emmartins
Copy link
Contributor

looks good to me, thanks @pferraro

@emmartins
Copy link
Contributor

ready to merge @pferraro ?

@emmartins emmartins merged commit 064caca into wildfly:master May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants