Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WFLY-18494 microprofile-fault-tolerance Quickstart Common Enhancements CY2023Q3 #808

Merged
merged 1 commit into from Dec 15, 2023

Conversation

rhusar
Copy link
Member

@rhusar rhusar commented Dec 13, 2023

@rhusar
Copy link
Member Author

rhusar commented Dec 13, 2023

@emmartins for review.

@emmartins
Copy link
Contributor

emmartins commented Dec 13, 2023 via email

Copy link
Contributor

@emmartins emmartins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small changes needed, please see individual threads

microprofile-fault-tolerance/README.adoc Outdated Show resolved Hide resolved
microprofile-fault-tolerance/pom.xml Outdated Show resolved Hide resolved
@emmartins
Copy link
Contributor

@rhusar please squash commits too

@rhusar
Copy link
Member Author

rhusar commented Dec 14, 2023

@rhusar please squash commits too

You want me to violate best SCM practices? Ouch.. but here you go. :) Squashed.

@emmartins
Copy link
Contributor

/retest

Copy link

openshift-ci bot commented Dec 15, 2023

@rhusar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/wildfly-quickstart-e2e e6f5c77 link true /test wildfly-quickstart-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

pom.xml Show resolved Hide resolved
@emmartins emmartins merged commit 416b334 into wildfly:main Dec 15, 2023
19 of 20 checks passed
@rhusar rhusar deleted the WFLY-18494 branch December 15, 2023 11:27
@rhusar
Copy link
Member Author

rhusar commented Dec 15, 2023

Excellent, thanks @emmartins and huge thanks to @kabir for starting this thing!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants