WFLY-18471 ha-singleton-deployment Quickstart Common Enhancements CY2023Q3 #914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhusar
commented
May 20, 2024
Comment on lines
+147
to
+152
| <!-- Tests --> | ||
| <dependency> | ||
| <groupId>org.junit.jupiter</groupId> | ||
| <artifactId>junit-jupiter-engine</artifactId> | ||
| <scope>test</scope> | ||
| </dependency> |
There was a problem hiding this comment.
@emmartins Please remind me, are you OK with JUnit 5 here?
…023Q3 Synchronize properties definitions. Convert the deployment to war from jar and introduce a welcome page via static index.html. Introduce a simple integration test and -Pintegration-tests Maven profile. Cleanup README file. Introduce automatic CI for the quickstart.
rhusar
changed the title
emmartins
approved these changes
May 27, 2024
Comment on lines
+147
to
+152
| <!-- Tests --> | ||
| <dependency> | ||
| <groupId>org.junit.jupiter</groupId> | ||
| <artifactId>junit-jupiter-engine</artifactId> | ||
| <scope>test</scope> | ||
| </dependency> |
|
good work, thanks |
|
Thanks @emmartins and again sorry for taking a while to finish this off. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
n.b. no OpenShift support and no bootable-jar support.
Resolves
https://issues.redhat.com/browse/WFLY-18471 – ha-singleton-deployment Quickstart Common Enhancements CY2023Q3
Related PR for ha-singleton-service QS: #915 (not conflicting)