[WFCORE-5489] As a developer, I want to override management attribute… #4816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
supersedes #4639 |
jmesnil
added
Feature
github-actions
bot
added
the
deps-ok
jmesnil
force-pushed
the
WFCORE-5489_override_attribute_value_from_env_var
branch
from
afdf45f
to
5afc50b
Compare
vsalbaba
reviewed
Oct 21, 2021
controller/src/test/java/org/jboss/as/controller/EnvVarAttributeOverrideModelTestCase.java
Outdated
Show resolved
Hide resolved
jmesnil
force-pushed
the
WFCORE-5489_override_attribute_value_from_env_var
branch
from
5afc50b
to
056c62b
Compare
|
Community Documentation is in PR wildfly/wildfly#14418 |
jmesnil
force-pushed
the
WFCORE-5489_override_attribute_value_from_env_var
branch
from
056c62b
to
cce4b54
Compare
|
LGTM |
bstansberry
reviewed
Nov 17, 2021
bstansberry
reviewed
Nov 17, 2021
controller/src/main/java/org/jboss/as/controller/AttributeDefinition.java
Outdated
Show resolved
Hide resolved
jmesnil
force-pushed
the
WFCORE-5489_override_attribute_value_from_env_var
branch
from
cce4b54
to
e8ef138
Compare
… values using environment variables When validating and setting the value for an non-complex attribute, check if there is an env var that would override its value before doing any expression resolution or correction. Complex attributes (object, property, list) does not allow overriding their value from an env var. This feature is enabled by the existence of the `WILDFLY_OVERRIDING_ENV_VARS` environment variable. The EnvVarAttributeOverrideModelTestCase test is executed in 2 different execution to test the behaviour with and without the env var that activates the feature. JIRA: https://issues.redhat.com/browse/WFCORE-5489 Signed-off-by: Jeff Mesnil <jmesnil@redhat.com>
jmesnil
force-pushed
the
WFCORE-5489_override_attribute_value_from_env_var
branch
from
e8ef138
to
7c284db
Compare
|
Looking good to me |
jmesnil
removed
the
missing-reqs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… values using environment variables
When validating and setting the value for an attribute, check if there is an env var
that would override its value before doing any expression resolution or
correction.
This feature is enabled by the existence of the
WILDFLY_OVERRIDING_ENV_VARSenvironment variable.JIRA: https://issues.redhat.com/browse/WFCORE-5489
Dev analysis is at wildfly/wildfly-proposals#404
Signed-off-by: Jeff Mesnil jmesnil@redhat.com