Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WFCORE-5489] As a developer, I want to override management attribute… #404

Merged
merged 1 commit into from
Nov 24, 2021
Merged

[WFCORE-5489] As a developer, I want to override management attribute… #404

merged 1 commit into from
Nov 24, 2021

Conversation

jmesnil
Copy link
Member

@jmesnil jmesnil commented Jun 25, 2021

… values using environment variables

JIRA: https://issues.redhat.com/browse/WFCORE-5489

Signed-off-by: Jeff Mesnil jmesnil@redhat.com

@jmesnil
Copy link
Member Author

jmesnil commented Jun 25, 2021

@kabir fiy, as it relates to https://issues.redhat.com/browse/WFCORE-5464 which also improves the configuration flexibility of WildFly

@jfdenise fiy, as this could help simplify some of our cloud deployment shenanigans (eg. the <cloud> CLI scripts as mentioned as an use case)

@jmesnil jmesnil mentioned this pull request Jun 25, 2021
Closed
@jmesnil jmesnil force-pushed the WFCORE-5489_override_attribute_value_from_env_var branch from 7722d9c to a899060 Compare June 25, 2021 15:57
@jmesnil jmesnil force-pushed the WFCORE-5489_override_attribute_value_from_env_var branch from a899060 to 100a0bc Compare July 2, 2021 09:35
@jmesnil jmesnil mentioned this pull request Jul 2, 2021
Merged
@jmesnil jmesnil force-pushed the WFCORE-5489_override_attribute_value_from_env_var branch from 100a0bc to ab797fa Compare October 18, 2021 08:26
bstansberry
bstansberry requested changes Nov 17, 2021
View reviewed changes
Copy link
Contributor

@bstansberry bstansberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made some comments on this but they don't imply any changes to the feature implementation; they're more about spelling out what will happen.

management/WFCORE-5489_override_attribute_value_from_env_var.adoc Outdated Show resolved Hide resolved
management/WFCORE-5489_override_attribute_value_from_env_var.adoc Show resolved Hide resolved
@jmesnil jmesnil force-pushed the WFCORE-5489_override_attribute_value_from_env_var branch 2 times, most recently from b88ace3 to 1df14e3 Compare November 19, 2021 08:28
@jmesnil
[WFCORE-5489] As a developer, I want to override management attribute…
3efcd14 
… values using environment variables

JIRA: https://issues.redhat.com/browse/WFCORE-5489

Signed-off-by: Jeff Mesnil <jmesnil@redhat.com>
@jmesnil jmesnil force-pushed the WFCORE-5489_override_attribute_value_from_env_var branch from 1df14e3 to 3efcd14 Compare November 19, 2021 08:28
@jmesnil
Copy link
Member Author

jmesnil commented Nov 19, 2021

@bstansberry I've updated the analysis, doc and code based on your feedback.
The main change is that this feature is not explicitly working only for simple attributes. Complex attributes are not taken into account in the code. (the community doc and analysis PR have been updated according to this change in the implementation).

@jmesnil jmesnil mentioned this pull request Nov 19, 2021
Merged
@jmesnil jmesnil merged commit 240fc2e into wildfly:main Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yersan yersan yersan left review comments

@bstansberry bstansberry bstansberry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jmesnil @bstansberry @yersan