Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFCORE-5489] Documentation for overridding the value of an attribute with an env var #14418

Conversation

jmesnil
Copy link
Member

@jmesnil jmesnil commented Jul 2, 2021

@jmesnil jmesnil added core-upgrade-needed PR requires a wildfly-core change to be merged and integrated first Feature-Docs PR documents a new feature coming via WildFly Core labels Jul 2, 2021
@jmesnil
Copy link
Member Author

jmesnil commented Jul 2, 2021

WildFly Core feature is at wildfly/wildfly-core/pull/4816
Dev analysis is at wildfly/wildfly-proposals#404

@jmesnil jmesnil force-pushed the WFCORE-5489_override_attribute_value_from_env_var branch from 974de1d to c5b89a2 Compare November 18, 2021 15:49
@jmesnil jmesnil force-pushed the WFCORE-5489_override_attribute_value_from_env_var branch from c5b89a2 to 6f3b651 Compare November 24, 2021 08:30
@vsalbaba
Copy link

LGTM

@jmesnil
Copy link
Member Author

jmesnil commented Nov 24, 2021

Dev PR has been merged at wildfly/wildfly-core#4816. This doc PR can be merged when the next wildfly-core release is incorporated in WildFly

@darranl darranl mentioned this pull request Nov 29, 2021
@darranl darranl merged commit ba65788 into wildfly:main Nov 30, 2021

[NOTE]
====
Complex attributes (which have their `type` set to `LIST, OBJECT`, or `PROPERTY`) can not be overridden using an environment variable.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

`LIST, OBJECT` -> `LIST`, `OBJECT`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-upgrade-needed PR requires a wildfly-core change to be merged and integrated first deps-ok Dependencies have been checked, and there are no significant changes Feature-Docs PR documents a new feature coming via WildFly Core
Projects
None yet
5 participants