-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WFCORE-5489] Documentation for overridding the value of an attribute with an env var #14418
Merged
darranl
merged 1 commit into
wildfly:main
from
jmesnil:WFCORE-5489_override_attribute_value_from_env_var
Nov 30, 2021
Merged
[WFCORE-5489] Documentation for overridding the value of an attribute with an env var #14418
darranl
merged 1 commit into
wildfly:main
from
jmesnil:WFCORE-5489_override_attribute_value_from_env_var
Nov 30, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmesnil
added
core-upgrade-needed
PR requires a wildfly-core change to be merged and integrated first
Feature-Docs
PR documents a new feature coming via WildFly Core
labels
Jul 2, 2021
WildFly Core feature is at wildfly/wildfly-core/pull/4816 |
github-actions
bot
added
the
deps-ok
Dependencies have been checked, and there are no significant changes
label
Jul 2, 2021
jmesnil
force-pushed
the
WFCORE-5489_override_attribute_value_from_env_var
branch
from
November 3, 2021 09:58
9ed951f
to
974de1d
Compare
bstansberry
requested changes
Nov 17, 2021
jmesnil
force-pushed
the
WFCORE-5489_override_attribute_value_from_env_var
branch
from
November 18, 2021 15:49
974de1d
to
c5b89a2
Compare
bstansberry
approved these changes
Nov 22, 2021
vsalbaba
reviewed
Nov 24, 2021
… with an env var JIRA: https://issues.redhat.com/browse/WFCORE-5489 Signed-off-by: Jeff Mesnil <jmesnil@redhat.com>
jmesnil
force-pushed
the
WFCORE-5489_override_attribute_value_from_env_var
branch
from
November 24, 2021 08:30
c5b89a2
to
6f3b651
Compare
LGTM |
Dev PR has been merged at wildfly/wildfly-core#4816. This doc PR can be merged when the next wildfly-core release is incorporated in WildFly |
Closed
rhusar
reviewed
Nov 30, 2021
|
||
[NOTE] | ||
==== | ||
Complex attributes (which have their `type` set to `LIST, OBJECT`, or `PROPERTY`) can not be overridden using an environment variable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
`LIST, OBJECT` -> `LIST`, `OBJECT`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
core-upgrade-needed
PR requires a wildfly-core change to be merged and integrated first
deps-ok
Dependencies have been checked, and there are no significant changes
Feature-Docs
PR documents a new feature coming via WildFly Core
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://issues.redhat.com/browse/WFCORE-5489
Signed-off-by: Jeff Mesnil jmesnil@redhat.com