-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WFLY-3810 Graceful shutdown support for mod_cluster #6914
Conversation
Linux Build 5418 is now running using a merge of 8249112 |
Linux Build 5418 outcome was FAILURE using a merge of 8249112 Build problems:Execution timeout |
8249112
to
99dfd12
Compare
Linux Build 5438 is now running using a merge of 99dfd12 |
Linux Build 5438 outcome was FAILURE using a merge of 99dfd12 Build problems:Failed tests detected Failed tests
|
Retest this please |
Linux Build 5450 is now running using a merge of 99dfd12 |
Linux Build 5450 outcome was FAILURE using a merge of 99dfd12 Build problems:Failed tests detected Failed tests
|
Unfortunately I haven't finished reviewing this, but last I was wondering whether we don't have to do a modcluster shutdown instead. But if the listener/connector is still handling CPING/CPONG for AJP and OPTIONS for HTTP when suspended then it shouldn't be a problem. |
Not answering to CPING or OPTIONS will just mark the node in error (in some cases after a timeout) |
Looking again at the code and design proposal, the server should answer to ping mechanisms even when paused. Therefore, I think this PR looks good and does what we need. 👍 |
Based on the above comments, I'm marking this ready for merge. |
WFLY-3810 Graceful shutdown support for mod_cluster
No description provided.