Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WFLY-13024 Integrate MP Fault Tolerance 2.1 #13003

Merged
merged 2 commits into from
Mar 4, 2020
Merged

WFLY-13024 Integrate MP Fault Tolerance 2.1 #13003

merged 2 commits into from
Mar 4, 2020

Conversation

rhusar
Copy link
Member

@rhusar rhusar commented Feb 17, 2020 •
edited
Loading

@bstansberry
Copy link
Contributor

@maeste FYI.

@rhusar CI won't run against Draft PRs, so if you want that you'll have to remove the 'Draft' status. I'm going to put 'Feature' and 'Missing Reqs' labels on this, and those will be enough to stop anyone inadvertently merging before it's ready.

Getting rid of lots of deps is nice!

@bstansberry bstansberry added Feature PR provides a new feature missing-reqs Features missing one or more of the pre-merge requirements labels Feb 17, 2020
@rhusar rhusar marked this pull request as ready for review February 17, 2020 22:38
@rhusar
Copy link
Member Author

rhusar commented Feb 17, 2020

Ok then, thanks Brian. Yeah, I did want to get the CI run results (while passing CI in our clustering CI env, the jobs are not 1:1).

@wildfly-ci wildfly-ci added the deps-ok Dependencies have been checked, and there are no significant changes label Feb 17, 2020
@bstansberry
Copy link
Contributor

Please remove https://issues.redhat.com/browse/WFLY-13122 from this PR. It is a separate issue. We need to be able to process WFLY-13024 independently.

@rhusar
Copy link
Member Author

rhusar commented Feb 18, 2020 •
edited
Loading

@bstansberry Sure, if that helps anything, extracted the commit into #13012.

@rhusar rhusar mentioned this pull request Feb 19, 2020
Merged
@tterem tterem mentioned this pull request Feb 20, 2020
Merged
@bstansberry bstansberry mentioned this pull request Feb 22, 2020
Closed
@rhusar
Copy link
Member Author

rhusar commented Feb 23, 2020

retest this please

@rhusar rhusar force-pushed the WFLY-13024 branch 2 times, most recently from 75108a2 to 594918c Compare March 2, 2020 23:28
@rhusar
Copy link
Member Author

rhusar commented Mar 4, 2020 •
edited
Loading

The latest CI failure is unrelated (not going to start a new run).

@rhusar
Copy link
Member Author

rhusar commented Mar 4, 2020

Pre-check passed: https://issues.redhat.com/browse/EAP7-1428?focusedCommentId=13989088&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13989088

cc @bstansberry @jamezp

@bstansberry bstansberry added the ready-for-merge Only for use by those with merge permissions! label Mar 4, 2020
@bstansberry bstansberry merged commit 1ea799a into wildfly:master Mar 4, 2020
@rhusar rhusar deleted the WFLY-13024 branch March 4, 2020 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maeste maeste maeste left review comments

@tterem tterem tterem requested changes

@bstansberry bstansberry bstansberry approved these changes

Assignees
No one assigned
Labels
deps-ok Dependencies have been checked, and there are no significant changes Feature PR provides a new feature missing-reqs Features missing one or more of the pre-merge requirements ready-for-merge Only for use by those with merge permissions!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rhusar @bstansberry @maeste @tterem @wildfly-ci