-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WFLY-10173 Fix EjbInvocationStatisticsTestCase#testSingletonWaitTime … #13346
WFLY-10173 Fix EjbInvocationStatisticsTestCase#testSingletonWaitTime … #13346
Conversation
90d68dc
to
d071f64
Compare
…(change the test to call async method of the same singleton)
d071f64
to
863944c
Compare
Windows JDK11 job has 1 failure in Artemis/jms: |
|
@chengfang Perhaps something like the "Example" at https://openejb.apache.org/examples-trunk/access-timeout/? What you have here is conceptually pretty similar though. |
I tried the above sample way of testing wait time, but didn't seem to work consistently. WF thread scheduling is undeterminstic and has a tendency to minimize context switching. Now I'm trying some mix of competing timer and method invocations, which theoretically should guarantee a postive wait time for business method invocations. |
…(start timers in test singleton bean to compete for the same bean instance)
Windows JDK11 job has 2 test failures (unrelated): |
Windows JDK11 failed again with 2 unrelated tests. Will rerun this build, which should also be beneficial just to make sure MissingClosingTagTestCase.commentIsNotClosed:
eap720.MixedDomainDeployment720TestCase:
|
Windows JDK11 failed again with unrelated test failure: |
@chengfang Regarding the MP FT failure I have opened smallrye/smallrye-fault-tolerance#244 - though this appears the only time it failed. |
@chengfang Can you kick in multiple runs on the CI to make sure with reasonable level of confidence that the intermittent failure is indeed fixed? (I would but I am not sure which job reproduces this the most which I assume you would know). |
Retest this please. |
Sure, I just restarted all jobs for this PR. |
Just FYI I have opened https://issues.redhat.com/browse/WFLY-13569 to deal with the failure mentioned in #13346 (comment) |
2 jobs failed with unrelated tests: Linux with sec JDK8 failed with:
Windows JDK11 failed with 422 failures (all unrelated) I will rerun these 2 builds. |
All CI jobs passed. So with my latest fix, the test in question ( |
JIRA: https://issues.redhat.com/browse/WFLY-10173
This should fix the intermitten test failure
EjbInvocationStatisticsTestCase#testSingletonWaitTime