Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WFLY-14930] Remove legacy feature packs and the builds and dists pro… #14394

Merged
merged 1 commit into from
Jul 8, 2021
Merged

[WFLY-14930] Remove legacy feature packs and the builds and dists pro… #14394

merged 1 commit into from
Jul 8, 2021

Conversation

bstansberry
Copy link
Contributor

@github-actions github-actions bot added the deps-ok Dependencies have been checked, and there are no significant changes label Jun 24, 2021
rhusar
rhusar suggested changes Jun 24, 2021
View reviewed changes
Copy link
Member

@rhusar rhusar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am afraid you also need to remove a couple of org.jboss.as.subsystem.test.AbstractSubsystemBaseTest#testSchemaOfSubsystemTemplates calls.

@bstansberry
Copy link
Contributor Author

Thanks, @rhusar. I wonder why those don't fail locally? Don't really much care though as we'll remove that infrastructure too!

@darranl
Copy link
Contributor

darranl commented Jun 26, 2021

Looks like a checkstyle error:

[ERROR] /store/work/tc- work/f5da3564a57e9d74/clustering/common/src/test/java/org/jboss/as/clustering/subsystem/ClusteringSubsystemTest.java:36:8: Unused import - org.junit.Test. [UnusedImports]

@bstansberry
Copy link
Contributor Author

@darranl @rhusar seems to be passing npw

darranl
darranl approved these changes Jul 8, 2021
View reviewed changes
Copy link
Contributor

@darranl darranl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should get this through, looks like it could either cause conflicts later or easily suffer conflicts.

rhusar
rhusar approved these changes Jul 8, 2021
View reviewed changes
Copy link
Member

@rhusar rhusar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, very exciting!

@bstansberry bstansberry merged commit 9e5c2ed into wildfly:master Jul 8, 2021
@bstansberry bstansberry deleted the WFLY-14930 branch July 8, 2021 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamezp jamezp jamezp approved these changes

@darranl darranl darranl approved these changes

@rhusar rhusar rhusar approved these changes

Assignees
No one assigned
Labels
deps-ok Dependencies have been checked, and there are no significant changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bstansberry @darranl @jamezp @rhusar