[WFLY-14980] add default 60s r/o timeout to listeners #15069
Conversation
github-actions
bot
added
the
deps-ok
|
@darranl please review |
|
@ropalka The needs a management API version bump and a transformer, so legacy host controller runs with a 60 s timeout if no value is explicitly configured. |
|
Hello @bstansberry , the bump is already in, see: a1f9ad7 |
|
@ropalka No, we didn't drop transformers, we just reduced the number of old releases we transform to to WF 23 or later. So this needs transformers. |
|
Fixed @bstansberry and thanks for the clarification. |
|
This should get it into WildFly @bstansberry before we will release it. ( @fl4via CC ) |
|
Just an FYI this is a long pending PR @bstansberry . |
|
Thanks @ropalka |
| .setDiscard(DiscardAttributeChecker.DEFAULT_VALUE, WRITE_TIMEOUT) | ||
| .setDiscard(DiscardAttributeChecker.DEFAULT_VALUE, READ_TIMEOUT) | ||
| .addRejectCheck(new SimpleRejectAttributeChecker(ModelNode.TRUE), WRITE_TIMEOUT.getName()) | ||
| .addRejectCheck(new SimpleRejectAttributeChecker(ModelNode.TRUE), READ_TIMEOUT.getName()); |
There was a problem hiding this comment.
This transformation does not look correct to me. A new default value should not result in any rejections, but rather use an AttributeConverter.
I've fixed this (and included missing tests) in this PR: #16455
| <xs:attribute name="read-timeout" type="xs:long" default="60000"/> | ||
| <xs:attribute name="write-timeout" type="xs:long" default="60000"/> |
There was a problem hiding this comment.
Version 13 was introduced in WF27. Modifications to XSDs are generally done in a new version.
I've patched this here: #16455
https://issues.redhat.com/browse/WFLY-14980
Follows on: #15041
Supersedes: #14595