Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove inline styling #47

Open
wilfredmulenga opened this issue Nov 2, 2019 · 0 comments
Open

remove inline styling #47

wilfredmulenga opened this issue Nov 2, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@wilfredmulenga
Copy link
Owner

wilfredmulenga commented Nov 2, 2019

It would be better to remove inline styles from components and add them to the App.scss file.
Rule for classes:

  • should follow kebab case e.g nav-bar-container;
  • should describe what the style does
@wilfredmulenga wilfredmulenga added enhancement New feature or request good first issue Good for newcomers labels Nov 2, 2019
@wilfredmulenga wilfredmulenga removed the good first issue Good for newcomers label Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant