-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supporting OpenLDAP 2.5 or newer #21
Comments
I don't know of any application using the LDAP support in PTLib and I don't think it really belongs in there anyway. |
Ah, I was looking at our ptlib port and noticed it had OpenLDAP as a dependency and with this recent patch added. Looking at the tree the only dependency I see using ptlib is h323plus. |
H.350 for which LDAP is used never really caught on so it would be fine to build PTLib without LDAP. |
I think it makes more sense to disable the LDAP support if it's truely not being used. If it's a fork of PTlib just for H323Plus why not remove that bit? |
There is no gain in removing the code. We can let configure fail in the detection for now. |
I disabled the OpenLDAP support in the ptlib port. https://marc.info/?l=openbsd-ports-cvs&m=166532629218883&w=2 |
Looking at PTLIB_FIND_OPENLDAP in ptlib.m4..
The macro hardcodes libldap_r for OpenLDAP. OpenLDAP 2.5 and newer has eliminated the libdap_r library and merged that into libldap. I'm not sure how you would want to deal with that. The OpenBSD port just has a diff to s/ldap_r/ldap/ but of course something better is necessary
The text was updated successfully, but these errors were encountered: