Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting OpenLDAP 2.5 or newer #21

Closed
brad0 opened this issue Oct 7, 2022 · 6 comments
Closed

Supporting OpenLDAP 2.5 or newer #21

brad0 opened this issue Oct 7, 2022 · 6 comments

Comments

@brad0
Copy link
Contributor

brad0 commented Oct 7, 2022

Looking at PTLIB_FIND_OPENLDAP in ptlib.m4..

          if test "x${ptlib_openldap}" = "xyes"; then  
            case "$target_os" in
            solaris* | sunos* )
                            dnl posix4 is required by libldap_r on Solaris
                            ptlib_openldap_libs="-lposix4"
                            ;;
                            * )
                            ptlib_openldap_libs="-llber -lldap_r"
            esac

The macro hardcodes libldap_r for OpenLDAP. OpenLDAP 2.5 and newer has eliminated the libdap_r library and merged that into libldap. I'm not sure how you would want to deal with that. The OpenBSD port just has a diff to s/ldap_r/ldap/ but of course something better is necessary

@willamowius
Copy link
Owner

willamowius commented Oct 7, 2022

I don't know of any application using the LDAP support in PTLib and I don't think it really belongs in there anyway.
Unless you have an application that needs it, I would tend depreciate it and stop building it by default if its causing any kind of issues.

@brad0
Copy link
Contributor Author

brad0 commented Oct 7, 2022

Ah, I was looking at our ptlib port and noticed it had OpenLDAP as a dependency and with this recent patch added. Looking at the tree the only dependency I see using ptlib is h323plus.

@willamowius
Copy link
Owner

H.350 for which LDAP is used never really caught on so it would be fine to build PTLib without LDAP.
If you want to keep LDAP alive on OpenBSD, send a pull request for configure.in.

@brad0
Copy link
Contributor Author

brad0 commented Oct 7, 2022

I think it makes more sense to disable the LDAP support if it's truely not being used. If it's a fork of PTlib just for H323Plus why not remove that bit?

@willamowius
Copy link
Owner

There is no gain in removing the code. We can let configure fail in the detection for now.

@brad0
Copy link
Contributor Author

brad0 commented Oct 9, 2022

I disabled the OpenLDAP support in the ptlib port.

https://marc.info/?l=openbsd-ports-cvs&m=166532629218883&w=2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants