fix: Allow parsing modules that have no symbols #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-auer
requested changes
Mar 2, 2021
There was a problem hiding this comment.
Thanks for the patch!
This actually means that the UnimplementedFeature error is in the wrong spot, and the check should be moved into fn symbols entirely. Each of the methods (symbols, lines) already returns Result, so it's best if we're graceful in parsing the entire module.
The expected CV Signature of a ModuleInfo seems to be a part of the symbols, meaning that we shouldn’t read it when the symbols_size is 0.
Swatinem
force-pushed
the
fix/module-zero-symbols
branch
from
8fcc84e
to
aa858ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The expected CV Signature of a ModuleInfo seems to be a part of the
symbols, meaning that we shouldn’t read it when the symbols_size is 0.