Fix invalid C13 inlinee line length #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fix is not yet verified as I'm lacking a proper test case at the moment. |
|
I verified that this fix does work for me. |
|
Added a test case based on the file provided by @mstange and verified manually. This should be ready now. |
jan-auer
force-pushed
the
fix/invalide-inlinee-line-length
branch
from
0c4ebe2
to
fce3a55
Compare
jan-auer
force-pushed
the
fix/invalide-inlinee-line-length
branch
from
fce3a55
to
1bf1d54
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes computation of the code length of inlinee line records if they are not declared explicitly in binary annotations.
In many cases, binary annotations set the code length explicitly using opcodes like
ChangeCodeLengthAndCodeOffset. In some cases, however, the compiler only advances the code offset usingChangeCodeOffsetAndLineOffset. In this case, the code length should be inferred by the difference from the last line record.The initial implementation wrongly subtracted the code offset base instead of the last offset. In this patch, the last offset is correctly subtracted.
Fixes #78