Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency socket.io to v2 [SECURITY] #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

renovate[bot]
Copy link

@renovate renovate bot commented Apr 26, 2021

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
socket.io ^1.3.5 -> ^2.5.1 age adoption passing confidence

GitHub Vulnerability Alerts

CVE-2020-28481

The package socket.io before 2.4.0 are vulnerable to Insecure Defaults due to CORS Misconfiguration. All domains are whitelisted by default.

CVE-2024-38355

Impact

A specially crafted Socket.IO packet can trigger an uncaught exception on the Socket.IO server, thus killing the Node.js process.

node:events:502
    throw err; // Unhandled 'error' event
    ^

Error [ERR_UNHANDLED_ERROR]: Unhandled error. (undefined)
    at new NodeError (node:internal/errors:405:5)
    at Socket.emit (node:events:500:17)
    at /myapp/node_modules/socket.io/lib/socket.js:531:14
    at process.processTicksAndRejections (node:internal/process/task_queues:77:11) {
  code: 'ERR_UNHANDLED_ERROR',
  context: undefined
}

Affected versions

Version range Needs minor update?
4.6.2...latest Nothing to do
3.0.0...4.6.1 Please upgrade to socket.io@4.6.2 (at least)
2.3.0...2.5.0 Please upgrade to socket.io@2.5.1

Patches

This issue is fixed by socketio/socket.io@15af22f, included in socket.io@4.6.2 (released in May 2023).

The fix was backported in the 2.x branch today: socketio/socket.io@d30630b

Workarounds

As a workaround for the affected versions of the socket.io package, you can attach a listener for the "error" event:

io.on("connection", (socket) => {
  socket.on("error", () => {
    // ...
  });
});

For more information

If you have any questions or comments about this advisory:

  • Open a discussion here

Thanks a lot to Paul Taylor for the responsible disclosure.

References


Release Notes

socketio/socket.io (socket.io)

v2.5.1

Compare Source

Bug Fixes
  • add a noop handler for the error event (d30630b)
Links:

v2.5.0

Compare Source

⚠️ WARNING ⚠️

The default value of the maxHttpBufferSize option has been decreased from 100 MB to 1 MB, in order to prevent attacks by denial of service.

Security advisory: GHSA-j4f2-536g-r55m

Bug Fixes
  • fix race condition in dynamic namespaces (05e1278)
  • ignore packet received after disconnection (22d4bdf)
  • only set 'connected' to true after middleware execution (226cc16)
  • prevent the socket from joining a room after disconnection (f223178)
Dependencies

4.5.1 (2022-05-17)

Bug Fixes
  • forward the local flag to the adapter when using fetchSockets() (30430f0)
  • typings: add HTTPS server to accepted types (#​4351) (9b43c91)
Dependencies

v2.4.1

Compare Source

Reverts
  • fix(security): do not allow all origins by default (a169050)

v2.4.0

Compare Source

Bug Fixes
  • security: do not allow all origins by default (f78a575)
  • properly overwrite the query sent in the handshake (d33a619)

3.0.4 (2020-12-07)

3.0.3 (2020-11-19)

3.0.2 (2020-11-17)

Bug Fixes
  • merge Engine.IO options (43705d7)

3.0.1 (2020-11-09)

Bug Fixes
  • export ServerOptions and Namespace types (#​3684) (f62f180)
  • typings: update the signature of the emit method (50671d9)

v2.3.0

Compare Source

This release mainly contains a bump of the engine.io and ws packages, but no additional features.

v2.2.0

Compare Source

Features
  • add cache-control header when serving the client source (#​2907) (b00ae50)
Bug fixes
  • throw an error when trying to access the clients of a dynamic namespace (#​3355) (a7fbd1a)

v2.1.1

Compare Source

Features
socket.local.to('room101').emit(/* */);

v2.1.0

Compare Source

Features
// by default, the object is recursively scanned to check whether it contains some binary data
// in the following example, the check is skipped in order to improve performance
socket.binary(false).emit('plain-object', object);

// it also works at the namespace level
io.binary(false).emit('plain-object', object);
io.of(/^\/dynamic-\d+$/).on('connect', (socket) => {
  // socket.nsp.name = '/dynamic-101'
});

// client-side
const client = require('socket.io-client')('/dynamic-101');
Bug fixes
Important note ⚠️ from Engine.IO 3.2.0 release

There are two non-breaking changes that are somehow quite important:

  • ws was reverted as the default wsEngine (https://github.com/socketio/engine.io/pull/550), as there was several blocking issues with uws. You can still use uws by running npm install uws --save in your project and using the wsEngine option:
var engine = require('engine.io');
var server = engine.listen(3000, {
  wsEngine: 'uws'
});

v2.0.4

Compare Source

Bug fixes

  • do not throw when receiving an unhandled error packet (#​3038)
  • reset rooms object before broadcasting from namespace (#​3039)
Links:

v2.0.3

Compare Source

Bug fixes

  • reset rooms object before broadcasting (#​2970)
  • fix middleware initialization (#​2969)
Links:

v2.0.2

Compare Source

Bug fixes

  • fix timing issues with middleware (#​2948)
Links:

v2.0.1

Compare Source

Bug fixes

- update path of client file (#​2934)

Links:

v2.0.0

Compare Source

This major release brings several performance improvements:

  • uws is now the default Websocket engine. It should bring significant improvement in performance (particularly in terms of memory consumption) (https://github.com/socketio/engine.io/releases/tag/2.0.0)

  • the Engine.IO and Socket.IO handshake packets were merged, reducing the number of roundtrips necessary to establish a connection. (#​2833)

  • it is now possible to provide a custom parser according to the needs of your application (#​2829). Please take a look at the example for more information.

Please note that this release is not backward-compatible, due to:

Please also note that if you are using a self-signed certificate, rejectUnauthorized now defaults to true (https://github.com/socketio/engine.io-client/pull/558).

Finally, the API documentation is now in the repository (here), and the content of the website here. Do not hesitate if you see something wrong or missing!

The full list of changes:

Besides, we are proud to announce that Socket.IO is now a part of open collective: https://opencollective.com/socketio. More on that later.

v1.7.4

Compare Source

  • [chore] Bump engine.io to version 1.8.4

v1.7.3

Compare Source

  • [chore] Bump engine.io-client to version 1.8.3

v1.7.2

Compare Source

  • [chore] Bump engine.io to version 1.8.2 (#​2782)
  • [fix] Fixes socket.use error packet (#​2772)

v1.7.1

Compare Source

(following socket.io-client update)

v1.7.0

Compare Source

  • [docs] Comment connected socket availability for adapters (#​2081)
  • [docs] Fixed grammar issues in the README.md (#​2159)
  • [feature] serve sourcemap for socket.io-client (#​2482)
  • [feature] Add a local flag (#​2628)
  • [chore] Bump engine.io to version 1.8.1 (#​2765)
  • [chore] Update client location and serve minified file (#​2766)

v1.6.0

Compare Source

  • [fix] Make ETag header comply with standard. (#​2603)
  • [feature] Loading client script on demand. (#​2567)
  • [test] Fix leaking clientSocket (#​2721)
  • [feature] Add support for all event emitter methods (#​2601)
  • [chore] Update year to 2016 (#​2456)
  • [feature] Add support for socket middleware (#​2306)
  • [feature] add support for Server#close(callback) (#​2748)
  • [fix] Don't drop query variables on handshake (#​2745)
  • [example] Add disconnection/reconnection logs to the chat example (#​2675)
  • [perf] Minor code optimizations (#​2219)
  • [chore] Bump debug to version 2.3.3 (#​2754)
  • [chore] Bump engine.io to version 1.8.0 (#​2755)
  • [chore] Bump socket.io-adapter to version 0.5.0 (#​2756)

v1.5.1

Compare Source

  • [fix] Avoid swallowing exceptions thrown by user event handlers (#​2682)
  • [test] Use client function to unify client in test script (#​2731)
  • [docs] Add link to LICENSE (#​2221)
  • [docs] Fix JSDoc of optional parameters (#​2465)
  • [docs] Fix typo (#​2724)
  • [docs] Link readme npm package badge to npm registry page (#​2612)
  • [docs] Minor fixes (#​2526)
  • [chore] Bump socket.io-parser to 2.3.0 (#​2730)
  • [chore] Add Github issue and PR templates (#​2733)
  • [chore] Bump engine.io to 1.7.2 (#​2729)
  • [chore] Bump socket.io-parser to 2.3.1 (#​2734)

v1.5.0

Compare Source

  • [feature] stop append /# before id when no namespace (#​2509)
  • [feature] Add a 'disconnecting' event to access to socket.rooms upon disconnection (#​2332)
  • [fix] Fix query string management (#​2422)
  • [fix] add quote to exec paths, prevent error when spaces in path (#​2508)
  • [docs] Prevent mixup for new programmers (#​2599)
  • [example] Fix chat display in Firefox (#​2477)
  • [chore] Add gulp & babel in the build process (#​2471)
  • [chore] Bump engine.io to 1.7.0 (#​2707)
  • [chore] Remove unused zuul-ngrok dependency (#​2708)
  • [chore] Point towards current master of socket.io-client (#​2710)
  • [chore] Restrict files included in npm package (#​2709)
  • [chore] Link build badge to master branch (#​2549)

v1.4.8

Compare Source

v1.4.7

Compare Source

v1.4.6

Compare Source

v1.4.5

Compare Source

v1.4.4

Compare Source

v1.4.3

Compare Source

v1.4.2

Compare Source

v1.4.1

Compare Source

v1.4.0

Compare Source

v1.3.7

Compare Source

v1.3.6

Compare Source


Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot changed the title Pin dependency socket.io to v1.7.4 [SECURITY] Pin dependency socket.io to 1.7.4 [SECURITY] May 9, 2021
@renovate renovate bot changed the title Pin dependency socket.io to 1.7.4 [SECURITY] Pin dependency socket.io to v1.7.4 [SECURITY] May 15, 2021
@renovate renovate bot changed the title Pin dependency socket.io to v1.7.4 [SECURITY] Pin dependency socket.io to v [SECURITY] Mar 7, 2022
@renovate renovate bot changed the title Pin dependency socket.io to v [SECURITY] Pin dependency socket.io to v1.7.4 [SECURITY] Sep 25, 2022
@renovate renovate bot force-pushed the renovate/npm-socket.io-vulnerability branch from b6bf794 to e9d504a Compare November 20, 2022 15:13
@renovate renovate bot changed the title Pin dependency socket.io to v1.7.4 [SECURITY] Update dependency socket.io to v4 [SECURITY] Nov 20, 2022
@renovate renovate bot force-pushed the renovate/npm-socket.io-vulnerability branch from e9d504a to 6d5cb92 Compare March 27, 2023 01:38
@renovate renovate bot changed the title Update dependency socket.io to v4 [SECURITY] Update dependency socket.io to v2 [SECURITY] Mar 27, 2023
@renovate renovate bot force-pushed the renovate/npm-socket.io-vulnerability branch from 6d5cb92 to 5607950 Compare May 28, 2023 15:59
@renovate renovate bot changed the title Update dependency socket.io to v2 [SECURITY] Update dependency socket.io to v4 [SECURITY] May 28, 2023
@renovate renovate bot force-pushed the renovate/npm-socket.io-vulnerability branch from 5607950 to 6cbb2e2 Compare June 1, 2023 03:34
@renovate renovate bot changed the title Update dependency socket.io to v4 [SECURITY] Update dependency socket.io to v2 [SECURITY] Jun 1, 2023
@renovate renovate bot force-pushed the renovate/npm-socket.io-vulnerability branch from 6cbb2e2 to 68399b0 Compare June 4, 2023 20:49
@renovate renovate bot changed the title Update dependency socket.io to v2 [SECURITY] Update dependency socket.io to v4 [SECURITY] Jun 4, 2023
@renovate renovate bot force-pushed the renovate/npm-socket.io-vulnerability branch from 68399b0 to a64e034 Compare June 10, 2023 02:10
@renovate renovate bot changed the title Update dependency socket.io to v4 [SECURITY] Update dependency socket.io to v2 [SECURITY] Jun 10, 2023
@renovate renovate bot force-pushed the renovate/npm-socket.io-vulnerability branch from a64e034 to 6311ef2 Compare June 14, 2023 02:54
@renovate renovate bot changed the title Update dependency socket.io to v2 [SECURITY] Update dependency socket.io to v4 [SECURITY] Jun 14, 2023
@renovate renovate bot changed the title Update dependency socket.io to v4 [SECURITY] Update dependency socket.io to v2 [SECURITY] Jun 17, 2023
@renovate renovate bot force-pushed the renovate/npm-socket.io-vulnerability branch 2 times, most recently from 8704126 to 9f25bbf Compare June 19, 2023 05:44
@renovate renovate bot changed the title Update dependency socket.io to v2 [SECURITY] Update dependency socket.io to v4 [SECURITY] Jun 19, 2023
@renovate renovate bot force-pushed the renovate/npm-socket.io-vulnerability branch from 9f25bbf to c177ad0 Compare June 23, 2023 02:42
@renovate renovate bot changed the title Update dependency socket.io to v4 [SECURITY] Update dependency socket.io to v2 [SECURITY] Jun 23, 2023
@renovate renovate bot force-pushed the renovate/npm-socket.io-vulnerability branch from c177ad0 to f2e500a Compare June 30, 2023 14:48
@renovate renovate bot changed the title Update dependency socket.io to v2 [SECURITY] Update dependency socket.io to v4 [SECURITY] Jun 30, 2023
@renovate renovate bot force-pushed the renovate/npm-socket.io-vulnerability branch from f2e500a to 560f229 Compare July 1, 2023 01:17
@renovate renovate bot changed the title Update dependency socket.io to v4 [SECURITY] Update dependency socket.io to v2 [SECURITY] Jul 1, 2023
@renovate renovate bot force-pushed the renovate/npm-socket.io-vulnerability branch from 560f229 to 705f952 Compare July 8, 2023 02:46
@renovate renovate bot changed the title Update dependency socket.io to v2 [SECURITY] Update dependency socket.io to v4 [SECURITY] Jul 8, 2023
@renovate renovate bot force-pushed the renovate/npm-socket.io-vulnerability branch from 0dbfe92 to a60725c Compare April 23, 2024 02:44
@renovate renovate bot changed the title Update dependency socket.io to v2 [SECURITY] Update dependency socket.io to v4 [SECURITY] Apr 23, 2024
@renovate renovate bot changed the title Update dependency socket.io to v4 [SECURITY] Update dependency socket.io to v2 [SECURITY] Apr 24, 2024
@renovate renovate bot force-pushed the renovate/npm-socket.io-vulnerability branch 2 times, most recently from e931bb3 to 61d4b33 Compare April 26, 2024 02:41
@renovate renovate bot changed the title Update dependency socket.io to v2 [SECURITY] Update dependency socket.io to v4 [SECURITY] Apr 26, 2024
@renovate renovate bot force-pushed the renovate/npm-socket.io-vulnerability branch from 61d4b33 to d0ab6fa Compare April 27, 2024 17:45
@renovate renovate bot changed the title Update dependency socket.io to v4 [SECURITY] Update dependency socket.io to v2 [SECURITY] Apr 27, 2024
@renovate renovate bot force-pushed the renovate/npm-socket.io-vulnerability branch from d0ab6fa to d7a8492 Compare May 1, 2024 11:50
@renovate renovate bot changed the title Update dependency socket.io to v2 [SECURITY] Update dependency socket.io to v4 [SECURITY] May 1, 2024
@renovate renovate bot force-pushed the renovate/npm-socket.io-vulnerability branch from d7a8492 to c585aeb Compare May 2, 2024 08:59
@renovate renovate bot changed the title Update dependency socket.io to v4 [SECURITY] Update dependency socket.io to v2 [SECURITY] May 2, 2024
@renovate renovate bot changed the title Update dependency socket.io to v2 [SECURITY] Update dependency socket.io to v4 [SECURITY] May 10, 2024
@renovate renovate bot force-pushed the renovate/npm-socket.io-vulnerability branch 2 times, most recently from d175b28 to a249754 Compare May 12, 2024 02:45
@renovate renovate bot changed the title Update dependency socket.io to v4 [SECURITY] Update dependency socket.io to v2 [SECURITY] May 12, 2024
@renovate renovate bot force-pushed the renovate/npm-socket.io-vulnerability branch from a249754 to af5df12 Compare May 23, 2024 02:31
@renovate renovate bot changed the title Update dependency socket.io to v2 [SECURITY] Update dependency socket.io to v4 [SECURITY] May 23, 2024
@renovate renovate bot force-pushed the renovate/npm-socket.io-vulnerability branch from af5df12 to 323c264 Compare May 24, 2024 14:53
@renovate renovate bot changed the title Update dependency socket.io to v4 [SECURITY] Update dependency socket.io to v2 [SECURITY] May 24, 2024
@renovate renovate bot force-pushed the renovate/npm-socket.io-vulnerability branch from 323c264 to 5476101 Compare June 5, 2024 17:56
@renovate renovate bot changed the title Update dependency socket.io to v2 [SECURITY] Update dependency socket.io to v4 [SECURITY] Jun 5, 2024
@renovate renovate bot force-pushed the renovate/npm-socket.io-vulnerability branch from 5476101 to beda3ef Compare June 8, 2024 02:08
@renovate renovate bot changed the title Update dependency socket.io to v4 [SECURITY] Update dependency socket.io to v2 [SECURITY] Jun 8, 2024
@renovate renovate bot force-pushed the renovate/npm-socket.io-vulnerability branch from beda3ef to 845c13d Compare June 19, 2024 23:12
@renovate renovate bot force-pushed the renovate/npm-socket.io-vulnerability branch from 845c13d to eaaccc0 Compare June 28, 2024 02:10
@renovate renovate bot changed the title Update dependency socket.io to v2 [SECURITY] Update dependency socket.io to v4 [SECURITY] Jun 28, 2024
@renovate renovate bot force-pushed the renovate/npm-socket.io-vulnerability branch from eaaccc0 to dbb3c30 Compare June 29, 2024 11:45
@renovate renovate bot changed the title Update dependency socket.io to v4 [SECURITY] Update dependency socket.io to v2 [SECURITY] Jun 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

0 participants