Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use cwd option on executable-handler #24

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

EduardoJM
Copy link
Contributor

closes #16

as i commented in the issue, the OBS (and many other softwares) uses the current working directory (cwd) to find configuration and other files. Add cwd path as opening file options solve the problem.

@willianrod
Copy link
Owner

@EduardoJM Thanks for your contribution ;)

I just checked here and it's working as expected. I had an issue while opening CS:GO cs.exe but this happens because CS needs to open thought steam. I'm thinking a Steam integration where would be really easy to select steam game.

Copy link
Owner

@willianrod willianrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Good catch ;)

@EduardoJM
Copy link
Contributor Author

I'm thinking a Steam integration where would be really easy to select steam game.

This is a really good. Do you know a way to do it?

@willianrod
Copy link
Owner

@EduardoJM Maybe using https://steamdb.info/ to do it. I'm working on refactoring all the handlers to be waaaay easier to develop new integrations, so I'm thinking on working on when the refactoring is completed.
I want to have the plugins implementation working before the hacktoberfest.

By the way, your PR will be merged this week, thanks again for the contribution. I'm organizing the project and making our goals more clear so more people can contribute

@EduardoJM
Copy link
Contributor Author

This is really a good project and if your have more issues that is not blocked by the refactoring the handlers, i want to work on it.

@willianrod
Copy link
Owner

@EduardoJM have you worked with github actions? I really want to add CI/CD to build and release new app versions, because right now I'm doing it manually

@EduardoJM
Copy link
Contributor Author

I worked with github actions to runs tests, to release packages to NPM/PyPI and to automatic deploy front-end's and back-end's in various providers. I can try to implement workflow to build and release the apps.

Maybe triggered by creating a new tag, and automatic create the release with the builded version?

@willianrod
Copy link
Owner

@EduardoJM thanks for your contribution ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] cannot open OBS executable
2 participants