Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] cannot open OBS executable #16

Closed
willianrod opened this issue Aug 20, 2023 · 3 comments · Fixed by #24
Closed

[bug] cannot open OBS executable #16

willianrod opened this issue Aug 20, 2023 · 3 comments · Fixed by #24
Assignees
Labels
bug Something isn't working

Comments

@willianrod
Copy link
Owner

willianrod commented Aug 20, 2023

Reported by: eujeffz

Expected Behavior

Open OBS correctly without any issues

Current Behavior

While trying to open OBS, an error is show. The error is coming from OBS failing to start properly. Tried with some other executables and works fine, just OBS that is having issues.

Steps to Reproduce

  1. Add a key to open an executable

  2. Select obs.exe inside obs folder obs-studio\bin\64bit\obs64.exe

  3. Hit save

  4. Press the key to open OBS in your deck

  5. You should see the error below now
    image

Possible Solution (Not obligatory)

Maybe we need to open OBS not as a child process? Just guessing

Context

Your Environment

  • ODeck version or branch : 0.0.4
  • Operating System and version : Windows
@willianrod willianrod added the bug Something isn't working label Aug 20, 2023
@EduardoJM
Copy link
Contributor

Maybe we need to open the process changing the cwd option to the executable path (see node child process documentation):

https://nodejs.org/api/child_process.html#child_processexecfilefile-args-options-callback

I can try to work on this bug

@willianrod
Copy link
Owner Author

@EduardoJM I didn't take the time to investigate but doing this should probably fix the issue. You can take this one if you want. Just confirm your interest and I'll assign you

@EduardoJM
Copy link
Contributor

Assign it to me, i will work on it today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants