Load atwho and caret explicitly in main with require #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidfurlong
added a commit
that referenced
this pull request
Nov 6, 2014
Load atwho and caret explicitly in main with require
|
Does it seem to eliminate the bug for you as well? On Thu, Nov 6, 2014 at 6:57 AM, David Furlong notifications@github.com
|
Ay. But the modal bug remains |
|
YES!! I will take a similar approach and start fixing the bbmodal (though the naive extention of just requiring bbmodal and its deps reintroduced new bugs) On Fri, Nov 7, 2014 at 2:25 AM, David Furlong notifications@github.com
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@davidfurlong This seems to improve things on production as I have not gotten the error on atwho after making this change.
Addresses #578
I did once see the error with bbmodal that you mentioned and am thinking of trying this same fix with it, but have run into some other weird bugs that get introduced.
In any case, see if this works to fix the atwho bug for you. This is the branch that is currently on http://www.cograph.co/