Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect Timezones in XMLs #162

Closed
joker234 opened this issue Jul 5, 2020 · 6 comments
Closed

Respect Timezones in XMLs #162

joker234 opened this issue Jul 5, 2020 · 6 comments

Comments

@joker234
Copy link
Contributor

joker234 commented Jul 5, 2020

With SotM 2020 (XML) using giggity I recognized, that reminders and program is not in local timezone but UTC. It would be nice if the local timezone (of the android device) would be used, but not that annoying. It's more annoying that I (currently in UTC+2) get the reminders two hours early. It would be nice if giggity could handle timezones properly.

The XML looks correct:

…
  <day index="1" date="2020-07-04" start="2020-07-04T10:00:00Z" end="2020-07-04T22:32:00Z">
    <room name="Track 1">
      <event guid="66470e9c-d19d-5670-9918-0248be67c02d" id="5028">
        <date>2020-07-04T10:00:00Z</date>
        <start>10:00</start>
        <duration>00:20</duration>
        <room>Track 1</room>
        <slug>sotm2020-5028-opening</slug>
        <url>https://pretalx.com/sotm2020/talk/AXAUHX/</url>
        <recording>
          <license></license>
          <optout>false</optout>
        </recording>
        <title>Opening</title>
        <subtitle></subtitle>
        <track>OSM Basics</track>
        <type>Talk</type>
        <language>en</language>
        <abstract>Welcome to SotM 2020!</abstract>
        <description>Welcome to SotM 2020!

Some words about how the virtual SotM will run.</description>
        <logo></logo>
        <persons>
          <person id="2297">SotM Working Group</person>
        </persons>
        <links/>
        <attachments/>
      </event>
…
@Wilm0r
Copy link
Owner

Wilm0r commented Jul 19, 2020

Agreed, I figured a few weeks ago that I'm going to have to add this to Giggity. When I wrote the parser, IIRC Pentabarf files didn't have useful tz info yet (also Java tz APIs were terrible, fortunately I've adopted a more modern one kinda recently which is going to be useful here).

When I considered implementing this earlier, I couldn't really figure out what to do UI-wise. But I guess it should just read all times with tz info and offer a choice between showing conf-local or user-local times (when they differ at all).

@Wilm0r
Copy link
Owner

Wilm0r commented Aug 16, 2020

This came up in #164 too, and I've managed to fix it in time before that event :-)

Behaviour is not configurable and will work only with Pentabarf files with those timestamps. Note that this is not in all Pentabarf style files for example not in FOSDEM's schedule: https://fosdem.org/2020/schedule/xml — it has only blocks with naive times, not the full-ISO8601 ones. But files that do, like HOPE and many others (in fact FOSDEM is the only exception I found so far) will now be parsed with timezone offset.

Then when tz offset is different from the phone's configured tz, the times will be converted, and the nav drawer will mention the offset as an FYI.

Alerts should all work properly now. Maybe later I'll add a setting to show event-local times. I think everything else it timezone-clean enough that this should work properly. (One could possibly try by just changing tzNative in Schedule.java.

@Wilm0r
Copy link
Owner

Wilm0r commented Aug 19, 2020

2.0.6 released on Play and hopefully soon F-Droid (depends on when their bot scans the repository)

Since some confs like FOSDEM don't have this info, and since hour offsets are less useful than actual timezone info, I wonder whether I'll just add a tz field to menu.json for more complete support later.

@Art1910
Copy link

Art1910 commented Aug 24, 2020

Updated on F-Droid + fixed my issue with the DebConf2020 schedule joining from UTC+2.
TYVM

@Wilm0r
Copy link
Owner

Wilm0r commented Sep 3, 2021

Since some confs like FOSDEM don't have this info, and since hour offsets are less useful than actual timezone info, I wonder whether I'll just add a tz field to menu.json for more complete support later.

IIRC I saw that Debconf does have a timezone header in its files somewhere which sounds useful. Guess support for that is worth keeping this bug open for.

@Wilm0r
Copy link
Owner

Wilm0r commented Mar 20, 2023

a079f48 did this already.

@Wilm0r Wilm0r closed this as completed Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants