-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Respect Timezones in XMLs #162
Comments
Agreed, I figured a few weeks ago that I'm going to have to add this to Giggity. When I wrote the parser, IIRC Pentabarf files didn't have useful tz info yet (also Java tz APIs were terrible, fortunately I've adopted a more modern one kinda recently which is going to be useful here). When I considered implementing this earlier, I couldn't really figure out what to do UI-wise. But I guess it should just read all times with tz info and offer a choice between showing conf-local or user-local times (when they differ at all). |
This came up in #164 too, and I've managed to fix it in time before that event :-) Behaviour is not configurable and will work only with Pentabarf files with those timestamps. Note that this is not in all Pentabarf style files for example not in FOSDEM's schedule: https://fosdem.org/2020/schedule/xml — it has only blocks with naive times, not the full-ISO8601 ones. But files that do, like HOPE and many others (in fact FOSDEM is the only exception I found so far) will now be parsed with timezone offset. Then when tz offset is different from the phone's configured tz, the times will be converted, and the nav drawer will mention the offset as an FYI. Alerts should all work properly now. Maybe later I'll add a setting to show event-local times. I think everything else it timezone-clean enough that this should work properly. (One could possibly try by just changing |
2.0.6 released on Play and hopefully soon F-Droid (depends on when their bot scans the repository) Since some confs like FOSDEM don't have this info, and since hour offsets are less useful than actual timezone info, I wonder whether I'll just add a tz field to |
Updated on F-Droid + fixed my issue with the DebConf2020 schedule joining from UTC+2. |
IIRC I saw that Debconf does have a timezone header in its files somewhere which sounds useful. Guess support for that is worth keeping this bug open for. |
a079f48 did this already. |
With SotM 2020 (XML) using giggity I recognized, that reminders and program is not in local timezone but UTC. It would be nice if the local timezone (of the android device) would be used, but not that annoying. It's more annoying that I (currently in UTC+2) get the reminders two hours early. It would be nice if giggity could handle timezones properly.
The XML looks correct:
The text was updated successfully, but these errors were encountered: