WINDUP-2031: Added carets, for better sorting visibility

windup · Jun 4, 2018 · 2bc421c · 2bc421c
1 parent ec3fa61
commit 2bc421c
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 4 deletions.
diff --git a/reporting/impl/src/main/resources/reports/resources/css/tech-report-punchcard.css b/reporting/impl/src/main/resources/reports/resources/css/tech-report-punchcard.css
@@ -39,6 +39,22 @@ tr.headersGroup td div {
     white-space: nowrap;
 }
 
+tr.headersGroup .sort_asc div:after {
+    content: "\f107";
+    font-family: "FontAwesome";
+    font-size: 10px;
+    font-weight: normal;
+    position: relative;
+}
+
+tr.headersGroup .sort_desc div:after {
+    content: "\f106";
+    font-family: "FontAwesome";
+    font-size: 10px;
+    font-weight: normal;
+    position: relative;
+}
+
 tr.app { font-size: 12pt; }
 tr.app td.name, tr.app td.sectorStats { padding: 0 0.5em; }
 tr.app td.name { white-space: nowrap; overflow: hidden;}

diff --git a/reporting/impl/src/main/resources/reports/templates/techReport-punchCard.ftl b/reporting/impl/src/main/resources/reports/templates/techReport-punchCard.ftl
@@ -198,18 +198,24 @@
         var reverse = false;
 
         function sortTable(column) {
+            // cleanup the previous sort classes
+            var groupedHeaderColumns = $('.headersGroup td').get();
+            groupedHeaderColumns.forEach(function(tdElement) {
+                $(tdElement).removeClass("sectorSorted");
+                $(tdElement).removeClass("sort_asc");
+                $(tdElement).removeClass("sort_desc");
+            });
+
             if (column == currentSortColumn) {
                 reverse = !reverse;
             } else {
                 reverse = false;
                 currentSortColumn = column;
             }
             var f = reverse ? 1 : -1;
-            var groupedHeaderColumns = $('.headersGroup td').get();
-            groupedHeaderColumns.forEach(function(tdElement) {
-                $(tdElement).removeClass("sectorSorted");
-            });
+
             $(groupedHeaderColumns[column]).addClass("sectorSorted");
+            $(groupedHeaderColumns[column]).addClass(reverse ? "sort_asc" : "sort_desc");
 
             var rows = $('.technologiesPunchCard tbody tr').get();