Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade aws-sdk to v2 #20

Merged
merged 7 commits into from
Sep 6, 2015
Merged

Upgrade aws-sdk to v2 #20

merged 7 commits into from
Sep 6, 2015

Conversation

eagletmt
Copy link
Member

@eagletmt eagletmt commented Sep 6, 2015

I'm testing this branch with my personal account.

Maybe many tests fail...

@winebarrel
Copy link
Collaborator

Would you like me to grant write access to the repository?

@eagletmt eagletmt changed the title [WIP] Upgrade aws-sdk to v2 Upgrade aws-sdk to v2 Sep 6, 2015
@eagletmt
Copy link
Member Author

eagletmt commented Sep 6, 2015

Now all tests are passing locally.

The Travis build is failing due to security restriction.
http://docs.travis-ci.com/user/pull-requests/#Security-Restrictions-when-testing-Pull-Requests
@winebarrel You can push my branch to winebarrel/roadworker to run tests in Travis.

@winebarrel
Copy link
Collaborator

Now all tests are passing locally.

👍

@winebarrel You can push my branch to winebarrel/roadworker to run tests in Travis.

Thanks!

winebarrel pushed a commit that referenced this pull request Sep 6, 2015
@winebarrel winebarrel merged commit 47ab4bf into cookpad:v0.5.5 Sep 6, 2015
@eagletmt eagletmt deleted the aws-sdk-v2 branch September 6, 2015 15:37
@eagletmt
Copy link
Member Author

eagletmt commented Sep 6, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants