Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

host.Unmount doesn't actually unmount #7

Closed
ncw opened this issue Apr 29, 2017 · 2 comments
Closed

host.Unmount doesn't actually unmount #7

ncw opened this issue Apr 29, 2017 · 2 comments

Comments

@ncw
Copy link
Contributor

ncw commented Apr 29, 2017

From host.go

// Mount unmounts a file system.
func (host *FileSystemHost) Unmount() {
	if nil != host.fuse {
		C.fuse_exit(host.fuse)
	}
}

However according to the fuse docs fuse_exit just stops the event loop, it doesn't do an unmount.

So this method should probably be renamed "Stop" or something like that.

An Unmount method would be really useful though. Here is how bazil/fuse does it for linux and everyone else. I'm guessing a different procedure would be needed for Windows.

@ncw
Copy link
Contributor Author

ncw commented Apr 29, 2017

Just realised that this is very much related to #6!

@billziss-gh
Copy link
Collaborator

As you mention this is a duplicate of #6. So let's continue this discussion there.

Thanks for the bazil/fuse links. They could prove useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants