Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reload of control files on file changes #6

Open
romangg opened this issue Aug 16, 2020 · 0 comments
Open

Reload of control files on file changes #6

romangg opened this issue Aug 16, 2020 · 0 comments
Labels
bug Something isn't working stage::decide

Comments

@romangg
Copy link
Member

romangg commented Aug 16, 2020

We currently only read the control files when the config hash changes (i.e. when the composition of outputs changes) but in some corner cases the control files might need to be reloaded even without such a change:

  1. When Disman is run in-process and some other process changes the config values.
  2. When the files were changed manually by the user.
  3. When in a parallel D-Bus/desktop session the control files were changed with a separate Disman backend service instance.

Cases 1 and 2 could be just declared as non-supported but 3 is a real issue albeit a very rare one.

We could implement a QFileSystemWatcher but this costs some resources (although when only done once in the D-Bus service backend probably allright) and makes Disman again a bit more dependent on Qt.

Overall the question is if the above cases can not be ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working stage::decide
Projects
None yet
Development

No branches or pull requests

1 participant